Remove unused filter-obj dependency - #43
Merged
Merged
Conversation
This was referenced Aug 3, 2026
ehmicky
approved these changes
Aug 3, 2026
ehmicky
left a comment
Owner
There was a problem hiding this comment.
Thanks a lot, this looks good!
Owner
|
@all-contributors Please add @HeversonSilva-gif for code. |
Contributor
|
I've put up a pull request to add @HeversonSilva-gif! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this pull request solving?
filter-objis listed independenciesbut nothing in the package uses it, so everyinstall resolves and downloads it for nothing.
List other issues or pull requests related to this problem
No existing issue. The same leftover declaration is in
all-node-versions(ehmicky/all-node-versions#45) andnode-version-alias(ehmicky/node-version-alias#44), where I have opened the same change. Since these three dependon one another,
filter-objonly leaves a consumer's tree once all three are merged.Describe the solution you've chosen
Removed the
filter-objentry fromdependenciesand letnpm installupdatepackage-lock.json. No source file changed.The only import was
import { excludeKeys } from 'filter-obj'insrc/options.js. Thatfile was deleted in b1b5de9 ("Reduce npm package size", 2022-10-16), and the dependency
declaration stayed behind.
Verified at dd5aab5 on Node 20.20.0:
git grep filter-objmatchespackage.jsonandpackage-lock.jsonand nothing else.Searching for
filterObjandfilter_objfinds nothing, so it is not imported underanother name.
npm testbefore the change: 9 tests passed, exit 0.npm testafter the change: 9 tests passed, exit 0.npm testruns prettier, eslint, jscpd and the type check in the same task, so those ranon both sides as well.
Describe alternatives you've considered
Moving it to
devDependencies. Nothing references it there either, including the tests,so there is nothing to keep it for.
Checklist
changed, so there is nothing new to cover and coverage is unaffected.
README.md, thedocsdirectory (if any). Notapplicable: no API, option or behaviour change.
opening the pull request; I will confirm once CI has run.