Adjust readmes to mention examples repo and sandbox api - #81
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates example app documentation to consistently reference the fishjam-cloud/examples repository layout and to clarify where to obtain/configure the Sandbox API URL needed to run the demos.
Changes:
- Added/updated README setup steps across several web and React Native demos to include copying
.env(.example)and sourcing Sandbox API URL from the sandbox dashboard. - Updated React Native READMEs to clone
fishjam-cloud/examplesand use the currentmobile-react-native/...paths. - Added
bump-fishjam.shto bump@fishjam-cloud/*SDK dependency versions across examples and runyarn installfor affected Yarn projects.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| web-react/text-chat/README.md | Adds README with .env + Sandbox API URL setup instructions. |
| web-react/livestreaming/README.md | Adds explicit environment-variable setup step including VITE_SANDBOX_API_URL. |
| web-react/fishjam-chat/README.md | Documents copying .env and sourcing VITE_SANDBOX_API_URL from the sandbox dashboard. |
| web-react/audio-only/README.md | Documents copying .env and sourcing VITE_SANDBOX_API_URL from the sandbox dashboard. |
| moq-demo/README.md | Adds .env option for providing VITE_SANDBOX_API_URL (in addition to query param/UI). |
| mobile-react-native/video-player/README.md | Updates repo/path instructions and adds EXPO_PUBLIC_SANDBOX_API_URL setup. |
| mobile-react-native/text-chat/README.md | Updates repo/path instructions, adds EXPO_PUBLIC_SANDBOX_API_URL, and simplifies lint instructions. |
| mobile-react-native/minimal-react-native/README.md | Updates repo/path instructions and adds EXPO_PUBLIC_SANDBOX_API_URL setup. |
| mobile-react-native/fishjam-chat/README.md | Updates repo/path instructions, adds EXPO_PUBLIC_SANDBOX_API_URL, and simplifies lint instructions. |
| mobile-react-native/blur-example/README.md | Updates repo/path instructions and adds EXPO_PUBLIC_SANDBOX_API_URL setup. |
| bump-fishjam.sh | Adds a repo-level helper to bump Fishjam SDK deps across examples and refresh Yarn lockfiles. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Karolk99
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.