fix(nextjs): Handle Middleware.execute root spans on Node.js runtime - #22013
Merged
Conversation
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 260bd40. Configure here.
chargome
marked this pull request as ready for review
July 7, 2026 11:26
chargome
requested review from
JPeer264,
logaretm,
mydea,
nicohrubec and
s1gr1d
and removed request for
a team and
mydea
July 7, 2026 11:26
JPeer264
approved these changes
Jul 7, 2026
49 tasks
This was referenced Jul 7, 2026
chargome
added a commit
that referenced
this pull request
Jul 22, 2026
…middleware root spans (#22232) On the edge runtime, Next.js's OTel instrumentation creates and samples the `Middleware.execute` root span before the Sentry middleware wrapper runs. So `normalizedRequest` was never on the isolation scope at sampling time, and tracesSampler received undefined. This adds a `beforeSampling` hook in the edge SDK which populates `normalizedRequest` (method, URL, query string) based on HTTP span attributes. It also extends the edge `spanStart` handler to fork the isolation scope for `Middleware.execute` root spans (similar to what #22013 did on the Node side after vercel/next.js#95357 made middleware a detached root span). The isolation-scope fork is extracted into a shared `maybeForkIsolationScopeForRootSpan` utility used by both the Node and edge handlers. Fixes #22200 --------- Co-authored-by: Charly Gomez <charly.gomez1310@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Middleware spans on node (
middelware/proxy) now run in a detached otel context makingMiddleware.executebecome root spans.We basically now mirror what we did in edge before by also calling
enhanceMiddlewareRootSpanon node. Additionally we had to fork isolation scopes on span start for these spans as these would scope leak otherwise.ref vercel/next.js#95357
closes #22001
closes #22002