fix(ci): Unblock external-contributors checkout on fork PR merges#22235
Open
Lms24 wants to merge 2 commits into
Open
fix(ci): Unblock external-contributors checkout on fork PR merges#22235Lms24 wants to merge 2 commits into
Lms24 wants to merge 2 commits into
Conversation
actions/checkout@v7 refuses any checkout in pull_request_target workflows triggered by fork PRs. Explicitly check out develop and opt in so the changelog credit workflow can run after external merges. Co-Authored-By: Cursor <cursoragent@cursor.com>
mydea
approved these changes
Jul 14, 2026
mydea
reviewed
Jul 14, 2026
Co-authored-by: Francesco Gringl-Novy <francesco.novy@sentry.io>
Comment on lines
+24
to
26
| with: | ||
| ref: develop | ||
| - name: Set up Node |
Contributor
There was a problem hiding this comment.
Bug: The workflow is missing allow-unsafe-pr-checkout: true in the checkout step, which was explicitly mentioned as part of the fix in the PR description.
Severity: MEDIUM
Suggested Fix
Add allow-unsafe-pr-checkout: true to the actions/checkout step in the workflow file. This aligns the code with the original intent described in the pull request and ensures the checkout step does not fail due to security restrictions in pull_request_target workflows.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: .github/workflows/external-contributors.yml#L24-L26
Potential issue: The `pull_request_target` workflow was updated to use
`actions/checkout@v7` and explicitly check out the `develop` branch. However, the change
omits `allow-unsafe-pr-checkout: true`, which was stated as necessary in the pull
request description. While checking out the base branch `ref: develop` might circumvent
the new security restrictions in `actions/checkout@v7`, the omission contradicts the
stated intent of the fix, which was prompted by a "broken run". This discrepancy
suggests the fix is incomplete and the workflow might still fail to check out code under
certain conditions.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The external-contributors workflow started failing after #21898 bumped
actions/checkoutto v7. That release blocks checkout inpull_request_targetworkflows when the triggering PR came from a fork, even when only checking out the base branch.This PR ensures we explicitly check out
developand setallow-unsafe-pr-checkout: true.The workflow never uses fork PR code. It only reads PR metadata from the
event payload and updates CHANGELOG.md on develop.
Broken run: https://github.com/getsentry/sentry-javascript/actions/runs/29263604917