Skip to content

feat(asgi): Apply data_collection filtering to URL query strings#6832

Open
ericapisani wants to merge 2 commits into
py-2583-query-parametersfrom
py-2583-query-params-asgi
Open

feat(asgi): Apply data_collection filtering to URL query strings#6832
ericapisani wants to merge 2 commits into
py-2583-query-parametersfrom
py-2583-query-params-asgi

Conversation

@ericapisani

@ericapisani ericapisani commented Jul 16, 2026

Copy link
Copy Markdown
Member

Filter query string parameters in the ASGI request data and span
attributes according to the data_collection.url_query_params config,
mirroring the existing WSGI behaviour. Falls back to the legacy
send_default_pii check when data_collection is not enabled.

Refs PY-2583
Refs #6743

Filter query string parameters in the ASGI request data and span
attributes according to the data_collection.url_query_params config,
mirroring the existing WSGI behaviour. Falls back to the legacy
send_default_pii check when data_collection is not enabled.

Refs PY-2583
Refs #6743
@linear-code

linear-code Bot commented Jul 16, 2026

Copy link
Copy Markdown

PY-2583

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

93419 passed | ⏭️ 6302 skipped | Total: 99721 | Pass Rate: 93.68% | Execution Time: 332m 24s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +1565
Passed Tests 📈 +1565
Failed Tests
Skipped Tests

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2479 uncovered lines.
✅ Project coverage is 89.72%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.67%    89.72%    +0.05%
==========================================
  Files          193       193         —
  Lines        24004     24119      +115
  Branches      8340      8420       +80
==========================================
+ Hits         21526     21640      +114
- Misses        2478      2479        +1
- Partials      1387      1391        +4

Generated by Codecov Action

@ericapisani ericapisani marked this pull request as ready for review July 16, 2026 17:21
@ericapisani ericapisani requested a review from a team as a code owner July 16, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant