feat(tornado): Apply data_collection filtering to URL query strings#6834
Open
ericapisani wants to merge 2 commits into
Open
feat(tornado): Apply data_collection filtering to URL query strings#6834ericapisani wants to merge 2 commits into
ericapisani wants to merge 2 commits into
Conversation
Rebuild url.full from the parsed base URL plus the filtered query string when data_collection is enabled, so filtered/redacted query params are reflected in url.full instead of the raw request query. Previously the unfiltered query string leaked into url.full even when data_collection filtering was active. Update the span-streaming tests to expect the filtered query in url.full (and a bare path when filtering strips all params). Refs PY-2583 Refs #6743
Replace .format(SENSITIVE_DATA_SUBSTITUTE) calls with hard-coded [Filtered] strings in the query param data collection test cases for clearer expectations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ericapisani
marked this pull request as ready for review
July 16, 2026 19:06
Contributor
Codecov Results 📊✅ 93749 passed | ⏭️ 6302 skipped | Total: 100051 | Pass Rate: 93.7% | Execution Time: 332m 13s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2480 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.67% 89.73% +0.06%
==========================================
Files 193 193 —
Lines 24004 24154 +150
Branches 8340 8448 +108
==========================================
+ Hits 21526 21674 +148
- Misses 2478 2480 +2
- Partials 1387 1394 +7Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuild url.full from the parsed base URL plus the filtered query string
when data_collection is enabled, so filtered/redacted query params are
reflected in url.full instead of the raw request query. Previously the
unfiltered query string leaked into url.full even when data_collection
filtering was active.
Update the span-streaming tests to expect the filtered query in url.full
(and a bare path when filtering strips all params).
Refs PY-2583
Refs #6743