C++: Implement guards logic for switch statements#15958
Merged
MathiasVP merged 9 commits intoMar 19, 2024
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
MathiasVP
force-pushed
the
ir-guards-from-switch-statements-2
branch
from
March 18, 2024 13:52
094e1be to
cb78f31
Compare
MathiasVP
force-pushed
the
ir-guards-from-switch-statements-2
branch
from
March 18, 2024 16:27
a56b5cd to
40dbc6f
Compare
MathiasVP
marked this pull request as ready for review
March 19, 2024 09:29
Contributor
|
I see some alert changes in DCA. Are those correct? |
Contributor
Author
I thought they were correct, but now that I look slightly closer I've spotted a problem. Thanks for making me double check them! I've fixed in this 350b239. Rerunning DCA now. |
Contributor
Author
|
I should've paid more attention to the test changes. They revealed the same problem >.< |
jketema
approved these changes
Mar 19, 2024
jketema
left a comment
jketema
left a comment
Contributor
There was a problem hiding this comment.
LGTM if DCA is happy this time around
Contributor
Author
|
DCA looks uneventful now (🎉 I guess 😄) |
This was referenced Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the follow-up to #15941 that addresses this comment I made in that PR:
Commit-by-commit review recommended.
This PR only does the required API additions to support
GuardCondition.comparesEqforswitchstatements. We also have a predicateGuardCondition.comparesLtwhich needs a similar treatment. I'm delaying that until a future PR