Skip to content

Java: get tainttracking3/TaintTrackingImpl.qll in sync#8811

Merged
aschackmull merged 1 commit into
github:mainfrom
erik-krogh:syncLate
Apr 22, 2022
Merged

Java: get tainttracking3/TaintTrackingImpl.qll in sync#8811
aschackmull merged 1 commit into
github:mainfrom
erik-krogh:syncLate

Conversation

@erik-krogh

Copy link
Copy Markdown
Contributor

#8748 added a copy of TaintTrackingImpl.qll.

But the shared implementation changed in the meantime.
So now we got the sync files check failing on main.

@erik-krogh
erik-krogh requested a review from a team as a code owner April 22, 2022 08:38
@github-actions github-actions Bot added the Java label Apr 22, 2022
@erik-krogh erik-krogh added the no-change-note-required This PR does not need a change note label Apr 22, 2022
@aibaars

aibaars commented Apr 22, 2022

Copy link
Copy Markdown
Contributor

The error message from QLDoc seems genuine:

A fatal error occurred: Errors during binding:
ERROR: This predicate does not override another predicate (/home/runner/work/codeql/codeql/java/ql/lib/semmle/code/java/dataflow/internal/tainttracking3/TaintTrackingImpl.qll:118,3-120,4)
ERROR: This predicate does not override another predicate (/home/runner/work/codeql/codeql/java/ql/lib/semmle/code/java/dataflow/internal/tainttracking3/TaintTrackingImpl.qll:135,3-137,4)

@erik-krogh

Copy link
Copy Markdown
Contributor Author

The error message from QLDoc seems genuine:

Yes. I'm confused about which file is actually the latest.

@aschackmull

Copy link
Copy Markdown
Contributor

The error message from QLDoc seems genuine:

Yes. I'm confused about which file is actually the latest.

Presumably that error is from main, and a side-effect of the files being out-of-sync. The change in this PR looks like the right fix to me.

@erik-krogh

Copy link
Copy Markdown
Contributor Author

Presumably that error is from main, and a side-effect of the files being out-of-sync. The change in this PR looks like the right fix to me.

Yes. Parts of the failing CI check is: HEAD is now at d309e150 Merge pull request #8748 from smowton/smowton/admin/dependent-dataflow-configs, which suggests that it is trying to compare against the failing main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants