Refactor schema validation error construction to remove duplicated invariant arguments

[Copilot]

internal/config/validation_server.go repeated the same SchemaValidationError(server.Type, ..., jsonPath, ...) pattern across custom-schema fetch/compile/validate paths. This change reduces that duplication by locally capturing invariant arguments while keeping all error messages and control flow intact.

• What changed

  • Added a local schemaErr(message, hint) closure in:
    • validateAgainstCustomSchema
    • validateServerAgainstSchema
  • Replaced repeated SchemaValidationError(server.Type, ..., jsonPath, ...) calls with schemaErr(...).

• Behavioral impact

  • No functional changes intended: same error conditions, same messages/hints, same returned error type/context.
  • Reduces boilerplate and lowers risk of future copy/paste inconsistency for server.Type / jsonPath.

• Example (pattern before/after)

  // before
  return SchemaValidationError(server.Type, msg, jsonPath, hint)
  
  // after
  schemaErr := func(message, hint string) error {
      return SchemaValidationError(server.Type, message, jsonPath, hint)
  }
  return schemaErr(msg, hint)

[Copilot]

Pull request overview

This PR refactors custom-schema validation in internal/config/validation_server.go to reduce repeated SchemaValidationError(server.Type, ..., jsonPath, ...) construction by introducing a small local helper closure (schemaErr) in the two functions that emit these errors, while keeping the same messages/hints and control flow.

Changes:

• Added a local schemaErr(message, hint) helper in validateAgainstCustomSchema.
• Added a local schemaErr(message, hint) helper in validateServerAgainstSchema.
• Replaced repeated SchemaValidationError(server.Type, ..., jsonPath, ...) call sites with schemaErr(...).

Show a summary per file

File	Description
internal/config/validation_server.go	Reduces boilerplate in custom-schema fetch/compile/validate error returns by capturing invariant args (server.Type, jsonPath) in a local helper.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0
• Review effort level: Low