Remove dependency on puppetdb-terminus if storeconfigs is not used#10
Merged
Conversation
added 6 commits
October 31, 2016 12:53
Contributor
Author
|
Hey @dalen could you take a look at this and confirm this is doing what I expect and not introducing any side effects? Basically in |
dalen
approved these changes
Nov 2, 2016
dalen
left a comment
There was a problem hiding this comment.
This looks reasonable as far as I can tell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request updates the documentation for configuring the path to Puppet, including tips on the
puppetdb-terminigem, and eliminating the dependency on that gem in the Puppet run if storeconfigs is not used. It also adds (hopefully) reasonable defaults for locating the Puppet binary.Inspired by #6