Skip to content

Remove dependency on puppetdb-terminus if storeconfigs is not used#10

Merged
kpaulisse merged 10 commits into
masterfrom
kpaulisse-puppetdb-termini
Nov 2, 2016
Merged

Remove dependency on puppetdb-terminus if storeconfigs is not used#10
kpaulisse merged 10 commits into
masterfrom
kpaulisse-puppetdb-termini

Conversation

@kpaulisse

@kpaulisse kpaulisse commented Oct 31, 2016

Copy link
Copy Markdown
Contributor

Overview

This pull request updates the documentation for configuring the path to Puppet, including tips on the puppetdb-termini gem, and eliminating the dependency on that gem in the Puppet run if storeconfigs is not used. It also adds (hopefully) reasonable defaults for locating the Puppet binary.

Inspired by #6

@kpaulisse kpaulisse changed the title Add notes about puppetdb-termini gem and defaults for example config Remove dependency on puppetdb-terminus if storeconfigs is not used Oct 31, 2016
@kpaulisse

Copy link
Copy Markdown
Contributor Author

Hey @dalen could you take a look at this and confirm this is doing what I expect and not introducing any side effects?

Basically in lib/octocatalog-diff/catalog-util/builddir.rb I changed the temporary copy of routes.yaml in the compilation directory to have facts - terminus = puppetdb changed to facts - terminus = yaml (or facts - terminus = facter). Keep in mind that :octocat:alog-diff pulls facts from PuppetDB and sticks them in a YAML file before puppet is ever invoked, so puppet itself is not ever hitting puppetdb unless it's doing storeconfigs as well.

@dalen dalen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable as far as I can tell.

@kpaulisse kpaulisse merged commit 83fc87e into master Nov 2, 2016
@kpaulisse kpaulisse deleted the kpaulisse-puppetdb-termini branch November 2, 2016 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants