feat: encrypt tokens using safe storage api - #1800
Merged
Merged
Conversation
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
setchy
changed the title
github-actions
Bot
added
the
enhancement
Member
Author
|
I ported ~95% of this from https://github.com/setchy/atlassify The 5% newness is handling both unecrypted tokens and encrypted tokens (Atlassify launched with encryption from its first GA release) |
Signed-off-by: Adam Setch <adam.setch@outlook.com>
|
bmulholland
reviewed
Feb 6, 2025
bmulholland
left a comment
bmulholland
left a comment
Collaborator
There was a problem hiding this comment.
Nice touch, thanks for considering security
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Electron's Safe Storage API to encrypt and decrypt tokens.
Still supports backwards compatibility.