feat(macos): launch as an agent app so no dock tile is ever created

electron-builder.js

@@ -24,6 +24,9 @@ const config = {
   mac: {
     category: 'public.app-category.developer-tools',
     icon: 'assets/images/app-icon.icns',
+    extendInfo: {
+      LSUIElement: true,
+    },
     identity: 'Adam Setch (5KD23H9729)',
     type: 'distribution',
     notarize: false, // Handle notarization in afterSign.js

src/main/lifecycle/first-run.test.ts

@@ -19,7 +19,6 @@ vi.mock('node:fs', () => ({
 const moveToApplicationsFolderMock = vi.fn();
 const isInApplicationsFolderMock = vi.fn(() => false);
 const getPathMock = vi.fn(() => '/User/Data');
-const dockHideMock = vi.fn();
 
 const showMessageBoxMock = vi.fn(async () => ({
   response: 0,
@@ -31,15 +30,7 @@ vi.mock('electron', () => ({
     getPath: () => getPathMock(),
     isInApplicationsFolder: () => isInApplicationsFolderMock(),
     moveToApplicationsFolder: () => moveToApplicationsFolderMock(),
-    dock: {
-      hide: () => dockHideMock(),
-    },
-  } satisfies Pick<
-    Electron.App,
-    'getPath' | 'isInApplicationsFolder' | 'moveToApplicationsFolder'
-  > & {
-    dock: { hide: () => void };
-  },
+  } satisfies Pick<Electron.App, 'getPath' | 'isInApplicationsFolder' | 'moveToApplicationsFolder'>,
   dialog: {
     showMessageBox: () => showMessageBoxMock(),
   } satisfies Pick<Electron.Dialog, 'showMessageBox'>,
@@ -134,19 +125,6 @@ describe('main/lifecycle/first-run', () => {
     expect(moveToApplicationsFolderMock).not.toHaveBeenCalled();
   });
 
-  it('re-hides the dock icon after the prompt closes (#3069)', async () => {
-    existsSyncMock.mockReturnValueOnce(false);
-    existsSyncMock.mockReturnValueOnce(false);
-    showMessageBoxMock.mockResolvedValueOnce({
-      response: 1,
-      checkboxChecked: false,
-    });
-
-    await onFirstRunMaybe();
-
-    expect(dockHideMock).toHaveBeenCalled();
-  });
-
   it('does not prompt on non-macOS', async () => {
     mac = false;
     existsSyncMock.mockReturnValueOnce(false);

src/main/lifecycle/first-run.ts

@@ -38,10 +38,6 @@ async function promptMoveToApplicationsFolder() {
     message: 'Move to Applications Folder?',
   });
 
-  // Parentless dialogs pull a dock-hidden (accessory) app into the Dock and
-  // macOS does not restore the accessory policy on close; re-hide (#3069).
-  app.dock?.hide();
-
   if (response === 0) {
     app.moveToApplicationsFolder();
   }

src/main/updater.test.ts

@@ -1,4 +1,4 @@
-import { app, dialog } from 'electron';
+import { dialog } from 'electron';
 import type { Menubar } from 'electron-menubar';
 
 import { APPLICATION } from '../shared/constants';
@@ -45,11 +45,6 @@ vi.mock('electron', () => {
     }
   }
   return {
-    app: {
-      dock: {
-        hide: vi.fn(),
-      },
-    },
     dialog: {
       showMessageBox: vi.fn(),
     } satisfies Pick<Electron.Dialog, 'showMessageBox'>,
@@ -145,7 +140,7 @@ describe('main/updater.ts', () => {
       expect(autoUpdater.quitAndInstall).toHaveBeenCalled();
     });
 
-    it('re-hides the dock icon when user dismisses the dialog (#3069)', async () => {
+    it('does not install when user dismisses the dialog', async () => {
       vi.mocked(dialog.showMessageBox).mockResolvedValue({
         response: 1, // "Later" button index
         checkboxChecked: false,
@@ -159,7 +154,6 @@ describe('main/updater.ts', () => {
       await Promise.resolve();
 
       expect(autoUpdater.quitAndInstall).not.toHaveBeenCalled();
-      expect(app.dock?.hide).toHaveBeenCalled();
     });
   });
 

src/main/updater.ts

@@ -1,4 +1,4 @@
-import { app, dialog, type MessageBoxOptions } from 'electron';
+import { dialog, type MessageBoxOptions } from 'electron';
 import type { Menubar } from 'electron-menubar';
 import { autoUpdater } from 'electron-updater';
 
@@ -200,14 +200,7 @@ export default class AppUpdater {
     dialog.showMessageBox(dialogOpts).then((returnValue) => {
       if (returnValue.response === 0) {
         autoUpdater.quitAndInstall();
-        return;
       }
-
-      // Presenting a parentless dialog forces a dock-hidden (accessory) macOS
-      // app to activate into the Dock, and the accessory policy is not
-      // restored when the dialog closes. Re-assert it so the dock icon
-      // disappears again (#3069).
-      app.dock?.hide();
     });
   }
 }