middleware: honour NoColor in defaultLogEntry.Panic#1086
Closed
alliasgher wants to merge 2 commits into
Closed
Conversation
Contributor
|
Needs a rebase. |
defaultLogEntry.Panic called PrintPrettyStack unconditionally, which always used ANSI colour codes regardless of the DefaultLogFormatter's NoColor field. Add PrintPrettyStackColor(rvr, useColor bool) and thread the flag through prettyStack.parse. PrintPrettyStack now delegates to it with useColor=true so existing callers are unaffected. defaultLogEntry.Panic passes l.useColor so the panic output respects the same flag that controls the rest of the request log. Fixes go-chi#1042 Signed-off-by: alliasgher <alliasgher123@gmail.com>
alliasgher
force-pushed
the
fix-logger-panic-nocolor
branch
from
22730e6 to
01faae4
Compare
Contributor
Author
|
Rebased onto master (01faae4). The wrap_writer fix that was in this branch already landed upstream, so this is now just the NoColor panic change. |
Address review: only defaultLogEntry.Panic needs the useColor variant and it lives in the same package, so PrintPrettyStackColor does not need to be exported. Rename it to printPrettyStack; the public PrintPrettyStack API is unchanged. Signed-off-by: alliasgher <alliasgher123@gmail.com>
Contributor
|
Merged via #1131. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultLogEntry.PaniccalledPrintPrettyStackunconditionally. That function hardcodesuseColor := true, so the panic stack trace was always printed with ANSI colour codes even whenDefaultLogFormatter.NoColorwas set totrue.Fix
PrintPrettyStackColor(rvr interface{}, useColor bool)that accepts an explicit colour flag.PrintPrettyStackto delegate to it withuseColor=true— no change for existing callers.prettyStack.parseto receiveuseColorrather than hardcode it.defaultLogEntry.Panicnow passesl.useColor, which is derived fromDefaultLogFormatter.NoColor.Fixes #1042