fix(middleware): Logger.Panic respects NoColor in DefaultLogFormatter#1125
Closed
happysnaker wants to merge 1 commit into
Closed
fix(middleware): Logger.Panic respects NoColor in DefaultLogFormatter#1125happysnaker wants to merge 1 commit into
happysnaker wants to merge 1 commit into
Conversation
defaultLogEntry.Panic() was calling PrintPrettyStack(v) without passing the NoColor preference from DefaultLogFormatter, so panic output always used color regardless of the NoColor setting. This adds an optional useColor parameter to PrintPrettyStack to preserve backward compatibility (defaults to true for the recoverer fallback path), and wires !l.NoColor through from the logger's Panic handler. Fixes go-chi#1042
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1042
defaultLogEntry.Panic()was callingPrintPrettyStack(v)without passing theNoColorpreference fromDefaultLogFormatter, so panic output always used color regardless of theNoColorsetting.Changes
useColor ...boolparameter toPrintPrettyStack(backward compatible, defaults totrue)!l.NoColorfromdefaultLogEntry.Panic()through toPrintPrettyStackBefore
Panic stack traces ignored the
NoColor: truesetting onDefaultLogFormatterand always used ANSI colors.After
When
DefaultLogFormatter{NoColor: true}is used, panic stack traces are also printed without ANSI color codes.