Skip to content

upgrade to unified uritemplate 3.0.0 [closes #57] - #293

Merged
theacodes merged 1 commit into
googleapis:masterfrom
venmo:uritemplate_unification
Oct 13, 2016
Merged

upgrade to unified uritemplate 3.0.0 [closes #57]#293
theacodes merged 1 commit into
googleapis:masterfrom
venmo:uritemplate_unification

Conversation

@simon-weber

Copy link
Copy Markdown
Contributor

As of uritemplate 3.0.0 and uritemplate.py 3.0.2, the two packages are equivalent.
There were no changes to functionality; see
https://github.com/sigmavirus24/uritemplate/blob/master/HISTORY.rst.

This resolves the conflict described in #57.

As of uritemplate 3.0.0 and uritemplate.py 3.0.2, the two packages are equivalent.
There were no changes to functionality; see
https://github.com/sigmavirus24/uritemplate/blob/master/HISTORY.rst.
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 13, 2016
@simon-weber

Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 13, 2016
@theacodes
theacodes merged commit c952fd0 into googleapis:master Oct 13, 2016
@theacodes

Copy link
Copy Markdown
Contributor

Thanks, @simon-weber!

@simon-weber

Copy link
Copy Markdown
Contributor Author

Sure thing. Any idea when this will be released? I'm eager to get rid of the special cases we had for resolving this 馃榿

@theacodes

Copy link
Copy Markdown
Contributor

Whenever I get the time to cut another release. Maybe sometime next week?

@simon-weber

Copy link
Copy Markdown
Contributor Author

Sounds good; thanks.

@simon-weber
simon-weber deleted the uritemplate_unification branch October 13, 2016 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants