Fix details missing in googleapiclient.errors.HttpError - #412
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
|
@sonlac thanks for sending this. I hate to be a bother, but could you update this to not change the indentation (or at least put the indentation change in its own commit)? It makes it extremely hard for me to review otherwise. |
Contributor
Author
|
@jonparrott Sorry about that. I just tried to reformat code to PEP8 style. Thanks. |
theacodes
approved these changes
Jul 17, 2017
Contributor
|
Thanks, @sonlac. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For instance, the googleapiclient.errors.HttpError returns only the message and the status code. Adding the error details on that would be useful and the error becomes slightly more verbose. In the response returned from the server, if the error body contains the details field, just show it together with the error message for more details. For example:
<HttpError 400 when requesting http://example.org returned "country is required". Details: "error details">Resolves: #382