Skip to content

fix: Update vision ITSystemTest to handle deviations in values returned by API #11596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhumin8 merged 7 commits into from
Jun 4, 2025
Merged

fix: Update vision ITSystemTest to handle deviations in values returned by API #11596

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c593657
fix: Update vision ITSystemTest to handle deviations in values return…
ldetmer May 27, 2025
b7beab1
fix format
ldetmer May 27, 2025
528803a
fix format
ldetmer May 30, 2025
0aedf58
update detectFacesGcsTest to handle similar deviation in returns
zhumin8 Jun 3, 2025
9fb7dad
fix lint
zhumin8 Jun 3, 2025
a3896e0
fix: remove old assert syntax.
zhumin8 Jun 3, 2025
c0fbb03
Merge branch 'main' into ldetmer-patch-1
zhumin8 Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions java-vision/google-cloud-vision/src/test/java/com/google/cloud/vision/it/ITSystemTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,8 @@ public void detectFacesTest() throws IOException {
for (FaceAnnotation annotation : assertNotEmpty(res, res.getFaceAnnotationsList())) {
assertThat(annotation.getAngerLikelihood()).isAnyOf(Likelihood.LIKELY, Likelihood.POSSIBLE);
assertEquals(Likelihood.VERY_UNLIKELY, annotation.getJoyLikelihood());
assertEquals(Likelihood.LIKELY, annotation.getSurpriseLikelihood());

@zhumin8 zhumin8 Jun 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know if there were any changes to the services that caused this deviation?
Also, seems L306 has similar problems. Recent log of failure in detectFacesGcsTest().

21:07:24:578 [ERROR] Failures: 
21:07:24:578 [ERROR]   ITSystemTest.detectFacesGcsTest:306 expected: but was:

assertThat(annotation.getSurpriseLikelihood())
.isAnyOf(Likelihood.LIKELY, Likelihood.POSSIBLE);
}
}

Expand All @@ -303,7 +304,8 @@ public void detectFacesGcsTest() throws IOException {
for (FaceAnnotation annotation : assertNotEmpty(res, res.getFaceAnnotationsList())) {
assertThat(annotation.getAngerLikelihood()).isAnyOf(Likelihood.LIKELY, Likelihood.POSSIBLE);
assertEquals(Likelihood.VERY_UNLIKELY, annotation.getJoyLikelihood());
assertEquals(Likelihood.LIKELY, annotation.getSurpriseLikelihood());
assertThat(annotation.getSurpriseLikelihood())
.isAnyOf(Likelihood.LIKELY, Likelihood.POSSIBLE);
}
}

Expand Down