Skip to content

test: Updates for Dual Region and testing - #1340

Merged
sydney-munro merged 2 commits into
mainfrom
dual-region
Apr 6, 2022
Merged

test: Updates for Dual Region and testing#1340
sydney-munro merged 2 commits into
mainfrom
dual-region

Conversation

@sydney-munro

Copy link
Copy Markdown
Contributor

Fixes #1304 ☕️

If you write sample code, please follow the samples format.

@sydney-munro sydney-munro added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 5, 2022
@sydney-munro sydney-munro self-assigned this Apr 5, 2022
@sydney-munro
sydney-munro requested a review from a team April 5, 2022 17:38
@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/java-storage API. label Apr 5, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 5, 2022
* this region.
* this region or regions.
*
* @see <a href="https://cloud.google.com/storage/docs/bucket-locations">Bucket Locations</a>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does dual-region have a link that we can direct folks to our is it just the bucket-locations doc?

cc: @danielbankhead

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will be here: https://cloud.google.com/storage/docs/locations

(the updates are currently in staging, pending for release)

@sydney-munro sydney-munro Apr 5, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it appears the link https://cloud.google.com/storage/docs/bucket-locations redirects to https://cloud.google.com/storage/docs/locations I can update this link.

although it is baked in quite a few places. I will open another PR after this to update docs references to the new location page.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found this doc (published yesterday) feel free to use in a future PR or in the change log/release notes: https://cloud.google.com/storage/docs/dual-regions

@danielbankhead

Copy link
Copy Markdown
Contributor

LGTM, may want another Java expert to review. Then, we'll merge once googleapis/python-storage#748 is unblocked

@danielbankhead danielbankhead added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 5, 2022
@sydney-munro sydney-munro removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 5, 2022
@sydney-munro
sydney-munro merged commit 83d5ee5 into main Apr 6, 2022
@sydney-munro
sydney-munro deleted the dual-region branch April 6, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Support for Dual Region Buckets

5 participants