Skip to content
This repository was archived by the owner on Jun 1, 2026. It is now read-only.

feat: use limited API to build PyPI wheels#254

Closed
mayeut wants to merge 5 commits into
googleapis:mainfrom
mayeut:limited-api
Closed

feat: use limited API to build PyPI wheels#254
mayeut wants to merge 5 commits into
googleapis:mainfrom
mayeut:limited-api

Conversation

@mayeut

@mayeut mayeut commented Oct 2, 2024

Copy link
Copy Markdown
Contributor

It was mentioned in #178, might as well propose something.

Mitigates #178

@mayeut
mayeut requested a review from a team October 2, 2024 18:15
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Oct 2, 2024
@edgarrmondragon

Copy link
Copy Markdown
Contributor

Python 3.13 was published a little over a week ago. Can we get eyes on this PR?

@ostefano

ostefano commented Jan 7, 2025

Copy link
Copy Markdown

@vchudnov-g can this be merged? Thanks!

@jlaine

jlaine commented Jan 29, 2025

Copy link
Copy Markdown

This is a fantastic idea @mayeut and will save headaches with every new Python version. I do hope it gets merged soon.

Comment thread scripts/manylinux/check.sh Outdated
@andrewsg andrewsg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 13, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 13, 2025
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Mar 17, 2025
@parthea parthea self-assigned this Mar 17, 2025
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 17, 2025
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Mar 17, 2025
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 17, 2025
Comment thread setup.py
CRC32C_PURE_PYTHON_EXPLICIT = "CRC32C_PURE_PYTHON" in os.environ
_FALSE_OPTIONS = ("0", "false", "no", "False", "No", None)
CRC32C_PURE_PYTHON = os.getenv("CRC32C_PURE_PYTHON") not in _FALSE_OPTIONS
# Wether or not we want to build using limited API (ABI3)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Whether is missing an h

@jlaine

jlaine commented Oct 13, 2025

Copy link
Copy Markdown

Any chance of revisiting this PR? It would have given us Python 3.14 compatible wheels for free :)

@chalmerlowe

Copy link
Copy Markdown

No promises, but let me see what I can do. Gonna let the kokoro checks run and then see if we can move this forward for everything including 3.14.

@flying-sheep

flying-sheep commented Nov 13, 2025

Copy link
Copy Markdown

Python 3.14 is released and my CI is spammed with hundreds of copies of

…/python3.14/site-packages/google_crc32c/__init__.py:29: RuntimeWarning: As the c extension couldn't be imported, `google-crc32c` is using a pure python implementation that is significantly slower. If possible, please configure a c build environment and compile the extension
  warnings.warn(_SLOW_CRC32C_WARNING, RuntimeWarning)

@chalmerlowe

Copy link
Copy Markdown

Migration Notice: This library is moving to the google-cloud-python monorepo soon.

We closed this PR due to inactivity to ensure a clean migration. Please re-open this work in the new monorepo once the migration is complete!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.