Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

fix: project_id need to be updated when Project.project_id is actually a project_number - #28

Closed
shanwei8 wants to merge 1 commit into
googleapis:masterfrom
shanwei8:patch-1
Closed

fix: project_id need to be updated when Project.project_id is actually a project_number #28
shanwei8 wants to merge 1 commit into
googleapis:masterfrom
shanwei8:patch-1

Conversation

@shanwei8

@shanwei8 shanwei8 commented Jul 22, 2020

Copy link
Copy Markdown

_connection.api_request(method="GET", path=f'/projects/{project_id}')
project_id here could be project number, and if you check Project('{project_id}').exists(), it will be True becasue api accept it.
When that happens, project_id should be updated too.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

_connection.api_request(method="GET", path=f'/projects/{project_id}')
project_id here could be project number, and if you check Project('{project_id}').exists(), it will be True becasue api accept it.
When that happens, project_id should be updated too.
@google-cla

google-cla Bot commented Jul 22, 2020

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 22, 2020
@shanwei8

Copy link
Copy Markdown
Author

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

@google-cla google-cla Bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 22, 2020
@shanwei8 shanwei8 changed the title Update project.py bug fix: project_id need to be updated when Project.project_id is actually a project_number Jul 22, 2020
@product-auto-label product-auto-label Bot added the api: cloudresourcemanager Issues related to the googleapis/python-resource-manager API. label Aug 21, 2020
@tseaver

tseaver commented Nov 13, 2020

Copy link
Copy Markdown
Contributor

@shanwei8 Can you please link the issue you created describing the problem?

@parthea parthea changed the title bug fix: project_id need to be updated when Project.project_id is actually a project_number fix: project_id need to be updated when Project.project_id is actually a project_number Apr 16, 2021
@parthea

parthea commented Jun 6, 2021

Copy link
Copy Markdown
Contributor

Superseded by #62

@parthea parthea closed this Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: cloudresourcemanager Issues related to the googleapis/python-resource-manager API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants