fix: project_id need to be updated when Project.project_id is actually a project_number - #28
fix: project_id need to be updated when Project.project_id is actually a project_number #28shanwei8 wants to merge 1 commit into
Conversation
_connection.api_request(method="GET", path=f'/projects/{project_id}')
project_id here could be project number, and if you check Project('{project_id}').exists(), it will be True becasue api accept it.
When that happens, project_id should be updated too.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
|
@shanwei8 Can you please link the issue you created describing the problem? |
|
Superseded by #62 |
_connection.api_request(method="GET", path=f'/projects/{project_id}')
project_id here could be project number, and if you check Project('{project_id}').exists(), it will be True becasue api accept it.
When that happens, project_id should be updated too.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕