Skip to content
This repository was archived by the owner on Apr 20, 2024. It is now read-only.

docs(samples): remove io dependency in transcribe samples - #223

Merged
nicain merged 6 commits into
googleapis:masterfrom
nicain:buganizer/188681681
Aug 10, 2021
Merged

docs(samples): remove io dependency in transcribe samples#223
nicain merged 6 commits into
googleapis:masterfrom
nicain:buganizer/188681681

Conversation

@nicain

@nicain nicain commented Aug 9, 2021

Copy link
Copy Markdown
Contributor
  • Refactor transcribe samples (transcribe_async) into two separate samples (transcribe_async_file and transcribe_async_gcs).
  • Remove dependency on io module (use open instead of io.open).
  • Fix small issue in argparse config for samples Remove CLI interface for the samples.
  • Update tests.

runner.sh:

set -e

ROOT='python-speech'

pytest ${ROOT?}/samples/snippets/transcribe_async_gcs_test.py
pytest ${ROOT?}/samples/snippets/transcribe_async_file_test.py

@snippet-bot

snippet-bot Bot commented Aug 9, 2021

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added api: speech Issues related to the googleapis/python-speech API. samples Issues that are directly related to samples. labels Aug 9, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2021
…l-file vs gcs) and remove io dependency. Refactor tests.
@nicain
nicain force-pushed the buganizer/188681681 branch from c6ba177 to 4bcd326 Compare August 9, 2021 19:25
@telpirion telpirion changed the title Remove io dependency in transcribe samples fix: remove io dependency in transcribe samples Aug 9, 2021

@telpirion telpirion left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a handful of comments.

Comment thread samples/snippets/transcribe_async_gcs.py Outdated
Comment thread samples/snippets/transcribe_async_gcs.py
Comment thread samples/snippets/transcribe_async_gcs.py Outdated
@parthea parthea changed the title fix: remove io dependency in transcribe samples docs(samples): remove io dependency in transcribe samples Aug 9, 2021
@nicain
nicain requested a review from telpirion August 9, 2021 21:22
Comment thread samples/snippets/transcribe_async_file.py Outdated
Comment thread samples/snippets/transcribe_async_file.py Outdated
Comment thread samples/snippets/transcribe_async_file_test.py Outdated
Comment thread samples/snippets/transcribe_async_file_test.py
Comment thread samples/snippets/transcribe_async_gcs.py Outdated
@nicain
nicain marked this pull request as ready for review August 10, 2021 19:01
@nicain
nicain merged commit 928ca3a into googleapis:master Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: speech Issues related to the googleapis/python-speech API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants