Update guava to 29.0 - #7079
Merged
Merged
Conversation
merge from origin
Contributor
Author
|
Contributor
Author
|
Foxed locally, for some reason the PR doesn't have that change. I hate git. |
elharo
commented
Jun 3, 2020
elharo
left a comment
Contributor
Author
There was a problem hiding this comment.
Exclusion of JUnit doesn't seem to be working. @dapengzhang0 any ideas?
dapengzhang0
reviewed
Jun 3, 2020
| testCompile libraries.junit, | ||
| libraries.mockito, | ||
| libraries.truth | ||
| testImplementation (libraries.guava_testlib) { |
Contributor
There was a problem hiding this comment.
Should not be done here. Search for usage of libraries.guava_testlib and change each of them with exclusion. (census/build.gradle uses libraries.guava_testlib but actually it should not)
dapengzhang0
approved these changes
Jun 3, 2020
| jetty_alpn_agent: 'org.mortbay.jetty.alpn:jetty-alpn-agent:2.0.9' | ||
| ] | ||
|
|
||
Contributor
Author
There was a problem hiding this comment.
| project(':grpc-grpclb'), | ||
| libraries.guava_testlib | ||
|
|
||
| testImplementation (libraries.guava_testlib) { |
Contributor
There was a problem hiding this comment.
Remove the comma above, otherwise this is considered as appending its return value to the above list, although not breaking.
Contributor
Author
|
Thanks. You need to merge this as I don't have committer rights. |
Contributor
|
@elharo Thank you for your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dapengzhang0 fixes #7053