deps: prepare to bump JUnit to 4.13

[elharo]

@dapengzhang0

[dapengzhang0]

@elharo Would you please fix failed test?

[elharo]

PTAL. Errors I found in the logs seemed to all be deprecated classes. Holler if you see any other errors I missed.

[elharo]

@dapengzhang0 This is proving surprisingly large. Can you please look at the kokoro results and confirm that the deprecations are the problem and that these need to be fixed in this PR?

[dapengzhang0]

guava-testlib v29 transitively depends on junit 4.13. In the codebase there are so many deprecations introduced by junit 4.13. Fixing that is invasive. Please revert the junit test fixes, and exclude junit dependency from guava-testlib instead:

testImplementation (libraries.guava_testlib) {
  exclude group: 'junit', module: 'junit'
}

Fixing deprecated usage of junit (optional) should be in another PR.

[elharo]

I don't want to revert all this work. We can have a new PR to update Guava and then use this to update JUnit.

Also, why do we depend on guava-testlib?

[dapengzhang0]

I don't want to revert all this work. We can have a new PR to update Guava and then use this to update JUnit.

I'm okay for a new PR. But the junit fix in this PR still has some problems.

[dapengzhang0]

Also, why do we depend on guava-testlib?

Some unit tests are using some utilities in guava-testlib.

[dapengzhang0]

@elharo We may not want to upgrade junit to 4.13 as of now, since internally we still use 4.12.

[elharo]

google-cloud-java and the rest of the open source GCP Java projects have pretty much already all moved to JUnit 4.13. We're not using anything newly introduced in 4.13 so internal google repos don't block this.

[elharo]

@dapengzhang0 This no longer updates dependencies. However it does update a much (though not all) code that will become deprecated once we move to JUnit 4.13.

[dapengzhang0]

Had a discussion with @ejona86 @voidzcy @sanjaypujare , we would like to keep the existing ExpectedException unchanged and only suppress the checker by adding @SuppressWarnings("ExpectedExceptionChecker"). In the future, when grpc migrates to Java 8, we can replace them with assertThrows() as recommended by the deprecation javadoc.

[ejona86]

I've created #7468 as an alternative to this PR.

[ejona86]

Closing in favor of #7468. Much less invasive. It'll be good when we can swap to assertThrows when it is convenient.

Thank you for this PR, even if it didn't get merged. I know it was quite annoying to swap to the try-fail approach. #7079 helped as well; I didn't have any conflicts when I bumped the junit version for testing.