xds: Enable Xds Client Fallback by default - #11817
Merged
Merged
Conversation
danielzhaotongliu
approved these changes
Jan 10, 2025
danielzhaotongliu
left a comment
danielzhaotongliu
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
Internally have been usingSystem.setProperty to enable xDS fallback. Now with this PR, this feature graduates from experimental and can remove the System.setProperty internally.
ejona86
approved these changes
Jan 10, 2025
ejona86
left a comment
ejona86
left a comment
Member
There was a problem hiding this comment.
Is there any reason to push and get this backported to 1.70, or are we just going to wait for 1.71?
Contributor
Author
|
I believe the only driver has been Prod, so it can wait for 1.71. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.