Skip to content

plumb otel subchannel metrics disconnect error - #12342

Merged
AgraVator merged 27 commits into
grpc:masterfrom
AgraVator:plumb-otel-subchannel-metrics-disconnect-error
Dec 23, 2025
Merged

plumb otel subchannel metrics disconnect error#12342
AgraVator merged 27 commits into
grpc:masterfrom
AgraVator:plumb-otel-subchannel-metrics-disconnect-error

Conversation

@AgraVator

@AgraVator AgraVator commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

Finishes the remaining work of A94

@AgraVator
AgraVator requested a review from ejona86 September 8, 2025 22:35
Comment thread binder/src/main/java/io/grpc/binder/internal/BinderClientTransport.java Outdated
Comment thread binder/src/main/java/io/grpc/binder/internal/BinderClientTransport.java Outdated
Comment thread core/src/main/java/io/grpc/internal/ClientTransportWithDisconnectReason.java Outdated
Comment thread netty/src/main/java/io/grpc/netty/NettyClientTransport.java Outdated
Comment thread netty/src/main/java/io/grpc/netty/NettyClientTransport.java Outdated
Comment thread okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java Outdated
Comment thread okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
Comment thread okhttp/src/test/java/io/grpc/okhttp/OkHttpClientTransportTest.java Outdated
@AgraVator
AgraVator force-pushed the plumb-otel-subchannel-metrics-disconnect-error branch 2 times, most recently from b6dce83 to 339ef99 Compare September 26, 2025 08:33
@AgraVator
AgraVator force-pushed the plumb-otel-subchannel-metrics-disconnect-error branch from 4df2777 to 2c3b757 Compare September 26, 2025 08:43
@AgraVator

Copy link
Copy Markdown
Contributor Author

last reviewed till 44fc3f9

@AgraVator
AgraVator requested a review from ejona86 October 13, 2025 09:12

@ejona86 ejona86 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments about SUBCHANNEL_SHUTDOWN are still outstanding, and would apply to the new shutdown() methods introduced (where I see some are UNKNOWN).

Comment thread okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
@AgraVator
AgraVator requested a review from ejona86 October 27, 2025 09:08

@ejona86 ejona86 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently I've had these comments just sitting around, thinking I had sent them.

Comment thread core/src/main/java/io/grpc/internal/ManagedClientTransport.java
Comment thread core/src/main/java/io/grpc/internal/KeepAliveManager.java Outdated
Comment thread okhttp/src/test/java/io/grpc/okhttp/OkHttpClientTransportTest.java Outdated
@AgraVator
AgraVator requested a review from ejona86 December 10, 2025 09:30
@AgraVator
AgraVator merged commit 6b2f758 into grpc:master Dec 23, 2025
17 checks passed
jdcormie pushed a commit to jdcormie/grpc-java that referenced this pull request Feb 11, 2026
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants