Add Cronet to main build - #6132
Conversation
TODO: adjust CI
20cb69c to
a710172
Compare
voidzcy
left a comment
voidzcy
left a comment
There was a problem hiding this comment.
Could we make the same change (not in this PR) to grpc-android?
| } | ||
| } | ||
|
|
||
| if (rootProject.properties.get('errorProne', true)) { |
There was a problem hiding this comment.
The indentation of this block may need to be fixed.
|
We should do this same thing for grpc-android and grpc-android-interop-testing (potentially removing the useless parent project that exists there today; "inline" |
| `<project-root>/gradle.properties` and add `skipCodegen=true`. | ||
|
|
||
| Some parts of grpc-java depend on Android. Since many Java developers don't have | ||
| the Android SDK installed and don't need to run or modify the Android |
There was a problem hiding this comment.
Are there instructions to install the Android SDK in case someone doesn't want to "skipAndroid"?
There was a problem hiding this comment.
It is basically download the SDK and set $ANDROID_HOME. But there's some complications that make it hard to be concise. I think I'll let @dapengzhang0 or @voidzcy add a documentation section later in this document, but after this is merged.
(Among the problems: ANDROID_HOME is actually deprecated now in favor of ANDROID_SDK_HOME, but we'd need to upgrade to a newer gradle plugin for ANDROID_SDK _HOME to work)
4 participants
This is a draft as the CI still needs to be adjusted and at will cause merge conflicts with #6130. I'm sending this out now so that it is more clear what #6131 permits. Note that this includes #6131, so much of it is noise; just look at the last commit.