xds: treat target server authority opaquely for resolving cluster name - #6767
Merged
Merged
Conversation
voidzcy
changed the title
…lve_treat_uri_opaquely
voidzcy
force-pushed
the
impl/xds_resolve_treat_uri_opaquely
branch
from
March 6, 2020 00:37
dd59721 to
db9e99e
Compare
voidzcy
added
the
TODO:backport
dapengzhang0
approved these changes
Mar 6, 2020
voidzcy
added a commit
to voidzcy/grpc-java
that referenced
this pull request
Mar 6, 2020
grpc#6767) Fixes usage of target hostname:port in xDS plugin. The target hostname:port used to construct gRPC channel should be treated opaquely. XdsNameResolver should not try to split it and should use it opaquely for sending LDS requests. In received RouteConfiguration messages, do not stripe off port (if any) for finding the virtual host with domain name matching the requested LDS resource name.
voidzcy
added a commit
to voidzcy/grpc-java
that referenced
this pull request
Mar 6, 2020
grpc#6767) Fixes usage of target hostname:port in xDS plugin. The target hostname:port used to construct gRPC channel should be treated opaquely. XdsNameResolver should not try to split it and should use it opaquely for sending LDS requests. In received RouteConfiguration messages, do not stripe off port (if any) for finding the virtual host with domain name matching the requested LDS resource name.
voidzcy
added a commit
that referenced
this pull request
Mar 6, 2020
#6767) (#6810) Fixes usage of target hostname:port in xDS plugin. The target hostname:port used to construct gRPC channel should be treated opaquely. XdsNameResolver should not try to split it and should use it opaquely for sending LDS requests. In received RouteConfiguration messages, do not stripe off port (if any) for finding the virtual host with domain name matching the requested LDS resource name.
ejona86
removed
the
TODO:backport
dfawley
pushed a commit
to dfawley/grpc-java
that referenced
this pull request
Jan 15, 2021
grpc#6767) Fixes usage of target hostname:port in xDS plugin. The target hostname:port used to construct gRPC channel should be treated opaquely. XdsNameResolver should not try to split it and should use it opaquely for sending LDS requests. In received RouteConfiguration messages, do not stripe off port (if any) for finding the virtual host with domain name matching the requested LDS resource name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6750.
The target hostname:port used to construct gRPC channel should be treated opaquely.
XdsNameResolvershould not try to split it and should use it opaquely for sending LDS requests. In receivedRouteConfigurationmessage, do not stripe off port (if any) for finding the virtual host with domain name matching the requested LDS resource name.