Skip to content

benchmark: clean up jmh plugin configurations - #6803

Merged
voidzcy merged 2 commits into
grpc:masterfrom
voidzcy:bugfix/fix_jmh_plugin_compatibility
Mar 5, 2020
Merged

benchmark: clean up jmh plugin configurations#6803
voidzcy merged 2 commits into
grpc:masterfrom
voidzcy:bugfix/fix_jmh_plugin_compatibility

Conversation

@voidzcy

@voidzcy voidzcy commented Mar 4, 2020

Copy link
Copy Markdown
Contributor
  • Bump jmh plugin version to 0.5.0, which is compatible with current Gradle version.
  • Removed unnecessary workaround for jmh known issues in previous version.
  • Fix dependencies to avoid getting duplicated class error when running jmhJar.

Fixes #6762.

@voidzcy
voidzcy requested a review from creamsoup March 4, 2020 23:30

@creamsoup creamsoup left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@voidzcy
voidzcy merged commit f85843b into grpc:master Mar 5, 2020
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
Bump jmh plugin to version 0.5.0. Put junit and mockito to test dependency. Eliminated jmh plugin config workaround for the known issue in previous version.
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot run jmh benchmarks

2 participants