buildscripts: update xds test server arg - #6816
Merged
Merged
Conversation
ericgribkoff
force-pushed
the
update_xds_job
branch
from
March 11, 2020 00:22
b1f2b46 to
d1ccbb1
Compare
dapengzhang0
approved these changes
Mar 11, 2020
| --gcp_suffix=$(date '+%s') \ | ||
| --verbose \ | ||
| --client_cmd='grpc-java/interop-testing/build/install/grpc-interop-testing/bin/xds-test-client --server=xds-experimental:///{service_host}:{service_port} --stats_port={stats_port} --qps={qps}' | ||
| --client_cmd='grpc-java/interop-testing/build/install/grpc-interop-testing/bin/xds-test-client --server=xds-experimental:///{server_uri} --stats_port={stats_port} --qps={qps}' |
Contributor
There was a problem hiding this comment.
nit: break the line at --server= etc
Contributor
There was a problem hiding this comment.
Oh, I didn't notice that it's inside a quote. Then it's not necessary. My bad.
Contributor
Author
There was a problem hiding this comment.
Still looks nicer with the line breaks :)
ericgribkoff
force-pushed
the
update_xds_job
branch
from
March 11, 2020 17:50
d21d757 to
aab0b19
Compare
ericgribkoff
force-pushed
the
update_xds_job
branch
from
March 11, 2020 17:51
aab0b19 to
ba0ddf1
Compare
This reverts commit ba0ddf1.
ericgribkoff
added a commit
to ericgribkoff/grpc-java
that referenced
this pull request
Mar 13, 2020
ericgribkoff
added a commit
that referenced
this pull request
Mar 13, 2020
dfawley
pushed a commit
to dfawley/grpc-java
that referenced
this pull request
Jan 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please excuse the numerous commits: the test results on
d1ccbb1are useful as the Android build log shows a successful run of the gRPC xDS job (probably should figure out a better way to test this on PRs, but for now the job only runs on master so this hack of borrowing another Kokoro job seems to work for PR testing).This depends on grpc/grpc#22297.
I also removed the Python package installation bits from our
xds.shscript as all prereqs are installed by the invocation ofprep_xds.shfrom the main repo.