Skip to content

rls: rls request factory (aka key builder map) - #6823

Merged
creamsoup merged 5 commits into
grpc:masterfrom
creamsoup:rls_request_factory
Apr 10, 2020
Merged

rls: rls request factory (aka key builder map)#6823
creamsoup merged 5 commits into
grpc:masterfrom
creamsoup:rls_request_factory

Conversation

@creamsoup

Copy link
Copy Markdown
Contributor

No description provided.

@creamsoup
creamsoup requested a review from dapengzhang0 March 13, 2020 01:46
@dapengzhang0 dapengzhang0 self-assigned this Mar 31, 2020
import javax.annotation.CheckReturnValue;

/**
* A RlsRequestFactory creates {@link RouteLookupRequest} using key builder map from {@link

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/A/An/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i read it a route lookup service request factory. so both are right depends on how you pronounce RLS.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, not a big deal.

Comment thread rls/src/test/java/io/grpc/rls/internal/RlsRequestFactoryTest.java Outdated
Comment thread rls/src/main/java/io/grpc/rls/internal/RlsRequestFactory.java Outdated
Comment thread rls/src/main/java/io/grpc/rls/internal/RlsRequestFactory.java Outdated
Comment thread rls/src/main/java/io/grpc/rls/internal/RlsRequestFactory.java Outdated
import javax.annotation.CheckReturnValue;

/**
* A RlsRequestFactory creates {@link RouteLookupRequest} using key builder map from {@link

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, not a big deal.

@creamsoup
creamsoup merged commit 1686d70 into grpc:master Apr 10, 2020
@creamsoup
creamsoup deleted the rls_request_factory branch April 10, 2020 22:56
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants