xds: fix style - #6834
Merged
Merged
Conversation
voidzcy
reviewed
Mar 16, 2020
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(targets); | ||
| return Objects.hashCode(targets); |
Contributor
There was a problem hiding this comment.
I am confused. In @dapengzhang0 's recent PR, he explicitly changed usages of Objects.hashCode() to Objects.hash(). So which one on earth should we use?
Contributor
Author
There was a problem hiding this comment.
according to the linter both generates same value. but hash accepts vararg, so it creates unnecessary objects when calling this method. the object is not really used in the hash based collection so it doesn't really matter tbh.
Contributor
There was a problem hiding this comment.
The recent PR was changing from guava Objects to java.util.Objects. It's a different issue.
voidzcy
approved these changes
Mar 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.