Implemented Frame Size Negotiation in ALTS for gRPC Java - #6840
Merged
Conversation
jiangtaoli2016
added
the
kokoro:force-run
grpc-kokoro
removed
the
kokoro:force-run
jiangtaoli2016
approved these changes
Apr 8, 2020
jiangtaoli2016
left a comment
jiangtaoli2016
left a comment
Contributor
There was a problem hiding this comment.
Thanks @ashithasantosh for PR.
Contributor
|
@ashithasantosh , please work with gRPC folks (e.g., @ejona86 ) on the internal patch, since you removed the function getMaxAllowedFrameBytes. |
Contributor
Author
|
I created a CL that imports this PR. After that CL is reviewed, we can merge this PR and then I will submit that CL. |
Contributor
Author
|
Thanks for the review, @jiangtaoli2016! |
jiangtaoli2016
added
the
kokoro:force-run
grpc-kokoro
removed
the
kokoro:force-run
dfawley
pushed a commit
to dfawley/grpc-java
that referenced
this pull request
Jan 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gRPC Java uses zero copy frame protectors, and hence are capable of handling larger frame size. Frame Size Negotiation support in ALTS, extends send frame size from 16KB to 128KB, and thereby improves performance.
Design Document: go/seal-frame-size-negotiation-alts