xds: ensure we shutdown XdsClientImpl when XDS Server is shut down - #6890
Merged
Conversation
…Server is shutdown
sanjaypujare
force-pushed
the
xds-server-shutdown
branch
from
April 1, 2020 21:54
76e3ca7 to
a4ed826
Compare
creamsoup
reviewed
Apr 1, 2020
creamsoup
reviewed
Apr 2, 2020
creamsoup
reviewed
Apr 3, 2020
creamsoup
left a comment
creamsoup
left a comment
Contributor
There was a problem hiding this comment.
sending what i have for now. seems like from last PR (or earlier) you have some formatting issue. please revisit and fix them. i tried to suggest some of those but probably not all (my suggestion might be misaligned as well because it is hard to tell from github ui).
…orsTest.java Co-Authored-By: Jihun Cho <jihuncho@google.com>
…ors.java Co-Authored-By: Jihun Cho <jihuncho@google.com>
Co-Authored-By: Jihun Cho <jihuncho@google.com>
sanjaypujare
changed the title
creamsoup
approved these changes
Apr 3, 2020
creamsoup
left a comment
creamsoup
left a comment
Contributor
There was a problem hiding this comment.
few nits, otherwise LGTM
Contributor
|
Oh my bad if it is just moved should be 2019. Git says it is added hmm
…On Fri, Apr 3, 2020 at 9:30 AM sanjaypujare ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In xds/src/test/java/io/grpc/xds/XdsServerBuilderTest.java
<#6890 (comment)>:
> @@ -0,0 +1,61 @@
+/*
+ * Copyright 2019 The gRPC Authors
The file was moved from under sds to this new location and a test was
added. Not sure if the year needs to be updated
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#6890 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJABOHKS4LBOWW7OFXE6R3RKYFLVANCNFSM4LZS7YJA>
.
|
Contributor
Author
It was moved and modified. git probably can't detect that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.