api: Fix javadoc reference to deprecated method - #6894
Merged
Conversation
Updates the `ManagedChannelBuilder#nameResolverFactory()`'s javadocs to refer to the new `NameResolverRegistry` instead of the deprecated `NameResolverProvider#providers()` method.
voidzcy
approved these changes
Apr 2, 2020
creamsoup
added
kokoro:run
grpc-kokoro
removed
kokoro:run
Contributor
|
merged, thanks @ST-DDT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
ManagedChannelBuilder#nameResolverFactory()'s javadocs to refer to the newNameResolverRegistryinstead of the deprecatedNameResolverProvider#providers()method.This is also closer to the truth for the default implementations:
grpc-java/core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java
Lines 251 to 255 in 84dd812