xds: eliminate downstreamTlsContext from XdsServerBuilder - #6901
Merged
Conversation
creamsoup
reviewed
Apr 6, 2020
sanjaypujare
force-pushed
the
xds-server-test
branch
from
April 7, 2020 16:11
bd6faa2 to
0f03cd9
Compare
creamsoup
reviewed
Apr 7, 2020
creamsoup
left a comment
creamsoup
left a comment
Contributor
There was a problem hiding this comment.
most comments in XdsSdsClientServerTest.java is still not resolved.
also, can you consider using rectangular rule? iirc i shared it with you before.
sanjaypujare
force-pushed
the
xds-server-test
branch
from
April 8, 2020 16:46
5f9261d to
be275e3
Compare
Update xds/src/main/java/io/grpc/xds/XdsClientWrapperForServerSds.java Co-Authored-By: Jihun Cho <jihuncho@google.com> Update xds/src/main/java/io/grpc/xds/XdsClientWrapperForServerSds.java Co-Authored-By: Jihun Cho <jihuncho@google.com>
sanjaypujare
force-pushed
the
xds-server-test
branch
from
April 9, 2020 16:18
be275e3 to
73f0158
Compare
Contributor
Author
|
rebased to resolve the merge conflict. |
creamsoup
reviewed
Apr 9, 2020
| public void createSslContextProvider_sdsConfigForCertValidationContext_expectException() { | ||
| CommonTlsContext commonTlsContext = | ||
| CommonTlsContextTestsUtil.buildCommonTlsContextFromSdsConfigForValidationContext( | ||
| CommonTlsContextTestsUtil.buildCommonTlsContextFromSdsConfigForValidationContext( |
Co-Authored-By: Jihun Cho <jihuncho@google.com>
Co-Authored-By: Jihun Cho <jihuncho@google.com>
creamsoup
approved these changes
Apr 13, 2020
creamsoup
left a comment
creamsoup
left a comment
Contributor
There was a problem hiding this comment.
few nits, otherwise LGTM in general.
| public static final String CA_PEM_FILE = "ca.pem"; | ||
| /** Bad/untrusted server certs. */ | ||
| public static final String BAD_SERVER_PEM_FILE = "badserver.pem"; | ||
|
|
Contributor
There was a problem hiding this comment.
nit: this is little weird. formatter does this because all the instance variables should have empty line. anyways, we can remove this
|
|
||
| @Before | ||
| public void setUp() throws IOException { | ||
| port = findFreePort(); |
Contributor
There was a problem hiding this comment.
nit: you can directly assign findFreePort() in L61.
dfawley
pushed a commit
to dfawley/grpc-java
that referenced
this pull request
Jan 15, 2021
* xds: eliminate downstreamTlsContext from XdsServerBuilder Co-authored-by: Jihun Cho <jihuncho@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.