rls: delegating helper for rls child policies - #6904
Merged
Conversation
creamsoup
changed the title
| this.picker = checkNotNull(picker, "picker"); | ||
| } | ||
|
|
||
| ChildLoadBalancerHelper forTarget(String target) { |
Contributor
There was a problem hiding this comment.
Is just Helper as return value type sufficient?
Contributor
Author
There was a problem hiding this comment.
yes, Helper is sufficient and it is usually better choice. I am worried about passing/using wrong helper. There will be another helper class (total 3 helpers - original from channel, this one and the other one not sent yet). Using it as Helper class confused me, so probably it will confuse other people.
dapengzhang0
approved these changes
Apr 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.