Remove unused function - #6911
Merged
Merged
Conversation
INFO: From Compiling external/io_grpc_grpc_java/compiler/src/java_plugin/cpp/java_generator.cpp [for host]:
external/io_grpc_grpc_java/compiler/src/java_plugin/cpp/java_generator.cpp:164:20: warning: unused function 'ShouldGenerateAsLite' [-Wunused-function]
static inline bool ShouldGenerateAsLite(const Descriptor* desc) {
^
1 warning generated.
|
|
creamsoup
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
dapengzhang0
approved these changes
Apr 8, 2020
Contributor
Contributor
|
LGTM, Seems, fine, not sure if I have a stake though. |
creamsoup
approved these changes
Apr 8, 2020
Contributor
|
merged, thanks @agasparovic-sabre! |
dfawley
pushed a commit
to dfawley/grpc-java
that referenced
this pull request
Jan 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INFO: From Compiling external/io_grpc_grpc_java/compiler/src/java_plugin/cpp/java_generator.cpp [for host]:
external/io_grpc_grpc_java/compiler/src/java_plugin/cpp/java_generator.cpp:164:20: warning: unused function 'ShouldGenerateAsLite' [-Wunused-function]
static inline bool ShouldGenerateAsLite(const Descriptor* desc) {
^
1 warning generated.