Skip to content

okhttp: Revert "okhttp: use new APIs for configuring TLS whenever possible (Android Q+) (#6912)" - #6946

Closed
voidzcy wants to merge 1 commit into
grpc:masterfrom
voidzcy:revert/revert_okhttp_use_new_api_to_configure_tls_android
Closed

okhttp: Revert "okhttp: use new APIs for configuring TLS whenever possible (Android Q+) (#6912)"#6946
voidzcy wants to merge 1 commit into
grpc:masterfrom
voidzcy:revert/revert_okhttp_use_new_api_to_configure_tls_android

Conversation

@voidzcy

@voidzcy voidzcy commented Apr 20, 2020

Copy link
Copy Markdown
Contributor

This reverts commit 5803dfd.

Roll forward after b/154375837 is resolved.

@voidzcy
voidzcy requested a review from ejona86 April 20, 2020 08:59
@voidzcy

voidzcy commented Apr 20, 2020

Copy link
Copy Markdown
Contributor Author

May not want to do the revert as the workaround seems to be obvious in #6949.

@ejona86

ejona86 commented Apr 20, 2020

Copy link
Copy Markdown
Member

That sounds fine as long as 1) you have tested the workaround and it appears to work, 2) you're coordinating with the person on-duty for the import, and 3) this doesn't get drawn out.

@voidzcy

voidzcy commented Apr 21, 2020

Copy link
Copy Markdown
Contributor Author

Close as #6469 is merged.

@voidzcy voidzcy closed this Apr 21, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants