Skip to content

rls: fake direct scheduled executor supports schedule - #6957

Merged
creamsoup merged 7 commits into
grpc:masterfrom
creamsoup:rls_lhlc
Apr 22, 2020
Merged

rls: fake direct scheduled executor supports schedule#6957
creamsoup merged 7 commits into
grpc:masterfrom
creamsoup:rls_lhlc

Conversation

@creamsoup

Copy link
Copy Markdown
Contributor

FYI. the schedule method is not used in this test, but will be used in other test.

Comment thread rls/src/main/java/io/grpc/rls/internal/LinkedHashLruCache.java Outdated
@creamsoup creamsoup changed the title rls: add invalidate(Key,Value), move out fake direct scheduled executor rls: fake direct scheduled executor supports schedule Apr 22, 2020
}

@Override
public ScheduledFuture<?> schedule(Runnable command, long delay, TimeUnit unit) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: final?

}
}

class FakeTimeProvider implements TimeProvider {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: final

return scheduledRunnable.scheduledFuture;
}

FakeTimeProvider getFakeTimeProvider() {

@dapengzhang0 dapengzhang0 Apr 22, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: final

@creamsoup
creamsoup merged commit 4a644cb into grpc:master Apr 22, 2020
@creamsoup
creamsoup deleted the rls_lhlc branch April 22, 2020 19:04
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants