all: bump protobuf to 3.12.0 - #7052
Merged
Merged
Conversation
ejona86
approved these changes
May 20, 2020
ejona86
left a comment
ejona86
left a comment
Member
There was a problem hiding this comment.
One very important typo fix, but otherwise LGTM
| sha256 = "e60211a40473f6be95b53f64559f82a3b2971672b11710db2fc9081708e25699", | ||
| strip_prefix = "protobuf-0425fa932ce95a32bb9f88b2c09b995e9ff8207b", | ||
| urls = ["https://github.com/google/protobuf/archive/0425fa932ce95a32bb9f88b2c09b995e9ff8207b.zip"], # Commit with fixed javalite on 3.11.x branch | ||
| name = "b37e96e81842af659605908a421960a5dc809acbc888f6b947bc320f8628e5b1", |
Member
There was a problem hiding this comment.
This name should not be changed.
Contributor
Author
There was a problem hiding this comment.
Oops, pasting too fast. I'm surprised Kokoro Bazel build passed.
Contributor
Author
|
@ejona86 I made a workaround in examples pom.xml. Sounds good to you? |
dapengzhang0
added
the
TODO:backport
This was referenced May 21, 2020
ejona86
removed
the
TODO:backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 3.12.0 is needed for the feature of support for proto3 field presence #7051