Skip to content

xds: add header matching special cases for hiding/exposing some gRPC headers - #7224

Merged
voidzcy merged 4 commits into
grpc:masterfrom
voidzcy:impl/add_special_case_header_matching_for_grpc_headers
Jul 22, 2020
Merged

xds: add header matching special cases for hiding/exposing some gRPC headers#7224
voidzcy merged 4 commits into
grpc:masterfrom
voidzcy:impl/add_special_case_header_matching_for_grpc_headers

Conversation

@voidzcy

@voidzcy voidzcy commented Jul 16, 2020

Copy link
Copy Markdown
Contributor
  • Expose "content-type" header (hard-coded) at header matching, pretend it's already there.
  • Hide "grpc-tags-bin", "grpc-trace-bin" and "grpc-previous-rpc-attempts", pretend they are not there.
  • Do not exclude binary headers from header matching, they can still be useful for present matchers (which checks if a given header present regardless its value).

Details in b/159631362

@voidzcy voidzcy closed this Jul 17, 2020
@voidzcy voidzcy reopened this Jul 17, 2020
@voidzcy
voidzcy requested a review from dapengzhang0 July 22, 2020 00:17
@voidzcy
voidzcy merged commit 1e238ee into grpc:master Jul 22, 2020
voidzcy added a commit to voidzcy/grpc-java that referenced this pull request Aug 11, 2020
…headers (grpc#7224)

Expose "content-type" header (hard-coded) at header matching, pretend it's already there.
voidzcy added a commit that referenced this pull request Aug 11, 2020
…headers (v1.31.x backport) (#7224) (#7313)

Expose "content-type" header (hard-coded) at header matching, pretend it's already there.
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
…headers (grpc#7224)

Expose "content-type" header (hard-coded) at header matching, pretend it's already there.
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants