Skip to content

Rename netty-shaded native resources directory to avoid collisions - #8270

Merged
sergiitk merged 1 commit into
grpc:masterfrom
dzou:netty-shaded-resource-followup
Sep 2, 2021
Merged

Rename netty-shaded native resources directory to avoid collisions#8270
sergiitk merged 1 commit into
grpc:masterfrom
dzou:netty-shaded-resource-followup

Conversation

@dzou

@dzou dzou commented Jun 17, 2021

Copy link
Copy Markdown
Contributor

This renames the netty-shaded resource folder to avoid configuration collisions with standard netty. Followup to: #8258 (comment)

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Sep 2, 2021
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Sep 2, 2021
@ejona86
ejona86 requested a review from sergiitk September 2, 2021 15:33

@sergiitk sergiitk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sergiitk
sergiitk merged commit ffebe23 into grpc:master Sep 2, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants