example: fix orca example to use new ORCA API - #9403
Merged
Conversation
ejona86
approved these changes
Jul 21, 2022
Member
There was a problem hiding this comment.
It'd be fair to implement toString in MetricReport if you want.
The fact this wasn't noticed earlier means we are failing to build this in our CI. It needs to be added
grpc-java/buildscripts/kokoro/unix.sh
Lines 62 to 84 in 50cdfa9
YifeiZhuang
added
the
TODO:backport
YifeiZhuang
added a commit
to YifeiZhuang/grpc-java
that referenced
this pull request
Jul 28, 2022
YifeiZhuang
added a commit
that referenced
this pull request
Jul 28, 2022
YifeiZhuang
removed
the
TODO:backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.