Skip to content

fix(datetime): days of week and spacing buttons are not announced by screen readers - #26813

Merged
liamdebeasi merged 5 commits into
mainfrom
FW-3490
Feb 16, 2023
Merged

fix(datetime): days of week and spacing buttons are not announced by screen readers#26813
liamdebeasi merged 5 commits into
mainfrom
FW-3490

Conversation

@liamdebeasi

@liamdebeasi liamdebeasi commented Feb 16, 2023

Copy link
Copy Markdown
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #26811

What is the new behavior?

  • Days of weeks label are not announced by screen readers
  • Spacing buttons are not announced by screen readers

Does this introduce a breaking change?

  • Yes
  • No

Other information

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions Bot added the package: core @ionic/core package label Feb 16, 2023
@liamdebeasi liamdebeasi changed the title Fw 3490 fix(datetime): days of week and spacing buttons are not announced by screen readers Feb 16, 2023
@liamdebeasi
liamdebeasi marked this pull request as ready for review February 16, 2023 17:48

@sean-perkins sean-perkins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for refactoring the day === null logic to a variable! Definitely have ran into that code and had to think "why would a day be null in calendar".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: datetime days of week and spacing buttons announced by screen readers

3 participants