fix(alert): match MD spec on tablet - #28501
Merged
Merged
Conversation
Co-authored-by: GlenOttley <GlenOttley@users.noreply.github.com>
liamdebeasi
commented
Nov 9, 2023
liamdebeasi
commented
Nov 9, 2023
liamdebeasi
commented
Nov 9, 2023
Contributor
Author
There was a problem hiding this comment.
Interestingly, I think this was a bug in Safari that I unintentionally fixed.
In main it looked correct on Chrome: https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-prompt-md-ltr-Mobile-Chrome-linux.png and Firefox: https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/alert/test/basic/alert.e2e.ts-snapshots/alert-prompt-md-ltr-Mobile-Firefox-linux.png
liamdebeasi
marked this pull request as ready for review
November 9, 2023 16:48
liamdebeasi
requested review from
a team,
averyrousseau and
brandyscarney
and removed request for
a team
November 9, 2023 16:48
Contributor
|
@liamdebeasi there's an open PR that also aims to fix the issue. Let's make sure that credit is given before merge. |
Contributor
Author
averyrousseau
suggested changes
Nov 10, 2023
averyrousseau
approved these changes
Nov 13, 2023
averyrousseau
approved these changes
Nov 14, 2023
brandyscarney
approved these changes
Nov 16, 2023
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Changes look good to me! Just a small nit pick on the comment style. 😎
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
2 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #23977
What is the current behavior?
The MD Alert on tablet dimensions does not match the MD spec
What is the new behavior?
Does this introduce a breaking change?
Other information
This supersedes #27462 since I needed to add new screenshot tests. The author of that PR has been given co-author credit here.