fix(alert): does not match MD spec for tablet dimensions - #27462
Closed
GlenOttley wants to merge 1 commit into
Closed
fix(alert): does not match MD spec for tablet dimensions#27462GlenOttley wants to merge 1 commit into
GlenOttley wants to merge 1 commit into
Conversation
|
|
2 tasks
Contributor
|
Thank you for the PR and apologies for the delay. I created a newer version of this PR using your changes as a base: #28501. I gave you co-author credit in this new PR as well. I am going to close this in favor of the linked PR. Let me know if you have any questions. |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
Issue number: resolves #23977 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The MD Alert on tablet dimensions does not match the MD spec ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - MD Alert now follows the MD spec for tablet dimensions - Added tablet and mobile viewport mixins for alert and the card modal. (There should be no visual diffs for the card modal) ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> This supersedes #27462 since I needed to add new screenshot tests. The author of that PR has been given co-author credit here. --------- Co-authored-by: GlenOttley <GlenOttley@users.noreply.github.com> Co-authored-by: ionitron <hi@ionicframework.com> Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #23977
Issue number: #23977
What is the current behavior?
All ion-alerts in md mode have a max width of 280px, and the alert content has a max height of 240px.
What is the new behavior?
ion-alert max width is now 560px, per MD spec
Does this introduce a breaking change?
Other information