bug: Detached nodes after dismissing modal

[aeharding]

Prerequisites

• I have read the Contributing Guidelines.
• I agree to follow the Code of Conduct.
• I have searched for existing issues that already report this problem, without success.

Ionic Framework Version

v7.x

Current Behavior

When using an Ionic Dialog, I see that HTML elements are retained after dismissal

Expected Behavior

No detached elements

Steps to Reproduce

1. npm build example app
2. Serve production build artifact (I use http-server dist)
3. Open Chrome devtools, garbage collect, take a heap snapshot
4. Open and dismiss dialog a few times
5. Garbage collect and take another heap snapshot
6. Compare snapshots
7. Observe there are many detached HTML elements, with pair in WeakMap retainers

Code Reproduction URL

https://github.com/aeharding/ionic-modal-leak

Ionic Info

Ionic:

   Ionic CLI       : 7.1.1 (/Users/aeharding/.nvm/versions/node/v20.8.1/lib/node_modules/@ionic/cli)
   Ionic Framework : @ionic/react 7.6.6

Capacitor:

   Capacitor CLI      : 5.6.0
   @capacitor/android : not installed
   @capacitor/core    : 5.6.0
   @capacitor/ios     : not installed

Utility:

   cordova-res : not installed globally
   native-run  : not installed globally

System:

   NodeJS : v20.8.1 (/Users/aeharding/.nvm/versions/node/v20.8.1/bin/node)
   npm    : 10.1.0
   OS     : macOS Unknown

Additional Information

[liamdebeasi]

Thanks for the report. There are two problems here:

1. We are not properly cleaning up the dismiss animation for overlays. This prevents the element from being garbage collected when using an inline overlay. This is being tracked in bug: IonModal with presentingElement doesn't render on iOS #28352, and we have in-progress work to resolve this: fix(overlays): tear down animations after dismiss #28907
2. There is a problem when using light DOM components in Stencil. This is being tracked in bug: light dom custom element with comment node causes retainer #28189. The Stencil team has a fix in place, and we are currently testing inside of Ionic.

I am going to close this issue in favor of the two linked ones. Let me know if you have questions.

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.