fix(overlays): tear down animations after dismiss - #28907
Merged
Conversation
3 tasks
thetaPC
requested changes
Jan 30, 2024
liamdebeasi
reviewed
Jan 31, 2024
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
liamdebeasi
approved these changes
Jan 31, 2024
liamdebeasi
left a comment
liamdebeasi
left a comment
Contributor
There was a problem hiding this comment.
Great job! I tested this in another app I was debugging, and it fixes one of the issues there as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28352
What is the current behavior?
Not all animations are getting properly destroyed after they run. This means that styles can get stuck at the end value of their animation.
Specifically for this reproduction (as reported in the bug ticket), if the modal animates from 1 to 0 opacity and then the modal gets reopened with a different animation where the opacity should be 1 throughout (i.e. the opacity isn't supposed to animate at all), the modal is invisible because the opacity got stuck at 0 and never got reset to the default value of 1.
This bug is probably causing some incorrect behavior on other edge cases with overlays, but this is the only one I've identified.
Reproduction steps
Note: you cannot reproduce this when using a modalController
iosmode on a screen wider than 768pxWhat is the new behavior?
Does this introduce a breaking change?