fix(angular): persist select disabled state in item - #29448
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sean-perkins
changed the title
sean-perkins
marked this pull request as ready for review
May 3, 2024 15:39
This was referenced Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29234
What is the current behavior?
In certain scenarios, such as in Angular where the property binding is set a few frames after the element is rendered, the
ionStyleevent fromion-selectcan be emitted beforeion-itemhas registered an event listener.This results in situations like setting the
ion-selectas initially disabled can cause the item to not treat the element as not interactable (receives pointer events).What is the new behavior?
ionStyleevent when theion-selectis rendered.ion-itemconsistently detects the state ofion-selectand applies the appropriate stylesDoes this introduce a breaking change?
Other information
Forked reproduction and dev-build available here: #29234 (comment)