Skip to content

fix(angular): persist select disabled state in item #29448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sean-perkins merged 2 commits into from
May 3, 2024
Merged

fix(angular): persist select disabled state in item #29448

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df5b5f8
fix(angular): persist select disabled state in item with IonicModule
sean-perkins May 2, 2024
cbca69d
chore: document change
sean-perkins May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions core/src/components/select/select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,10 +241,6 @@ export class Select implements ComponentInterface {
this.ionChange.emit({ value });
}

componentWillLoad() {
this.inheritedAttributes = inheritAttributes(this.el, ['aria-label']);
}

async connectedCallback() {
const { el } = this;

Expand All @@ -270,6 +266,24 @@ export class Select implements ComponentInterface {
});
}

componentWillLoad() {
this.inheritedAttributes = inheritAttributes(this.el, ['aria-label']);
}

componentDidLoad() {
/**
* If any of the conditions that trigger the styleChanged callback
* are met on component load, it is possible the event emitted
* prior to a parent web component registering an event listener.
*
* To ensure the parent web component receives the event, we
* emit the style event again after the component has loaded.
*
* This is often seen in Angular with the `dist` output target.
*/
this.emitStyle();
}

disconnectedCallback() {
if (this.mutationO) {
this.mutationO.disconnect();
Expand Down